fix: move CSS imports from @Theme to bootstrap JS file #22518
Conversation
flow-server/src/main/java/com/vaadin/flow/server/frontend/scanner/FrontendDependencies.java
Show resolved
Hide resolved
...pplication-theme/src/test/java/com/vaadin/flow/webcomponent/ApplicationThemeComponentIT.java
Outdated
Show resolved
Hide resolved
|
|
||
| protected <T> List<String> merge(Map<T, List<String>> css) { | ||
| protected <T> List<String> merge(Map<T, List<String>> outputFiles) { | ||
| // Ignore app shell imports and definitions for bundle build detection, |
There was a problem hiding this comment.
Shouldn't app shell imports also be taken into account by flow as they are not added to the general imports anymore even though they were there before?
There was a problem hiding this comment.
Apart from unit tests, the feature that is affected here is the bundle build.
Should the bundle include theme CSS imports? I don't know, but the current implementation didn't. So I assumed that my changes at some point produced a valid failure in the bundle ITs because of including CSS imports again. Ignoring here addresses this failure.
There was a problem hiding this comment.
@mshabarov what was the state for css in bundles.
From what I see in tests and code I would expect css to be bundles and Theme css especially
There was a problem hiding this comment.
I see. Bundles were including the css, but stats.json wasn't indicating that, because it didn't consider the new file with their imports. Hope this change helps it: 9b23bc1
|
|
flow-server/src/main/java/com/vaadin/flow/server/frontend/AbstractUpdateImports.java
Show resolved
Hide resolved
|
4 participants
Fixes #22517